search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

v10.1 should be sent up #126

Closed GrylledCheez closed 1 year ago

GrylledCheez commented 1 year ago

@Fmstrat, there was a regression in v10 that took out some important code by @phavekes

We re-added it and set a new release of v10.1 if you wanted to send that to gnome. Otherwise check PR #124 for v11

oenu commented 1 year ago

Listed install process gives V7, current == V10.1, is there a documented way to install latest?

Fmstrat commented 1 year ago

@GrylledCheez If 11 is already ready for merge, I'll give that one a shot today on my systems so we can make the jump. Thank you!

GrylledCheez commented 1 year ago

@oenu this is in the new README. Grab the develop branch

Building from source

  1. Download source code from the Master or develop branches.
  2. unzip the file
  3. cd into the directory it creates
  4. run ./build.sh
  5. run unzip wintile@nowsci.com.zip
  6. run cp -r wintile@nowsci.com ~/.local/share/gnome-shell/extensions/
  7. restart your session

Wayland users need to reboot to enable the extension.

Gnome users can press <Alt>+<F2> and run r from the prompt. (IT WILL NOT WORK from a terminal)

Fmstrat commented 1 year ago

You could also clone directly into the extensions folder, and run build.sh and be done. This way you can do a git pull to get the latest version in the future. That being said, given the great work of contributors we should have a new version out soon.

GrylledCheez commented 1 year ago

Just make sure you "git checkout develop" before you build. That way you'll be in bleeding edge :D

Fmstrat commented 1 year ago

Just make sure you "git checkout develop" before you build. That way you'll be in bleeding edge :D

You brave soul.

GrylledCheez commented 1 year ago

You brave soul.

I stand by my edits

Fmstrat commented 1 year ago

@GrylledCheez develop won't activate for me. master seems to work fine, however. I'm running X11 and GNOME shell version 3.36 in Ubuntu 20.04. Any thoughts before I try to debug?

Note: I also reset the column default to 2 in develop. Since existing users have that as default, changing to 3 if they've never updated that setting will force them into 3 column mode unexpectedly.

GrylledCheez commented 1 year ago

And you ran build.sh before you started? Does it look activated on the tweak tool? Did you make sure that the extension-updates folder was empty? If not then it will be "updated" to v7 when you restart the session.

GrylledCheez commented 1 year ago

@Fmstrat, debug with this journalctl -qf |grep -i -e Wintile -e 'js error'

Fmstrat commented 1 year ago

Yea looks like log was switched for console.log, which doesn't exist in 3.36 (Ubuntu 20.04). Glad I still haven't upgraded.

Fmstrat commented 1 year ago

Ok, only thing I found in develop was when using arrow keys if you're in an upper/lower corner and try to go farther it jumps to 100% height, but that's fine to me. Any cleanup required before a master merge?

GrylledCheez commented 1 year ago

Go ahead and give the _log function an if else to use console.log or global.log or I can do it in a bit

GrylledCheez commented 1 year ago

@Fmstrat. Ready to merge when you are. Just need approval

Fmstrat commented 1 year ago

@GrylledCheez What's wrong with log? Does it not work in all platforms?

GrylledCheez commented 1 year ago

It's fine. I changed it originally because I got a warning on a stricter version eslint rules. That was before I added /* global global */ to the header.

GrylledCheez commented 1 year ago

Ok, only thing I found in develop was when using arrow keys if you're in an upper/lower corner and try to go farther it jumps to 100% height, but that's fine to me. Any cleanup required before a master merge?

No further cleanup required. Go ahead and approve the pull-request. Thanks for letting me be a part of this.