search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Create CONTRIBUTING.md #136

Closed GrylledCheez closed 1 year ago

GrylledCheez commented 1 year ago

Includes most of the common errors that cause eslint to fail.

GrylledCheez commented 1 year ago

@phavekes, thoughts?

phavekes commented 1 year ago

I would prefer to move the linting stuff to a github action, instead of manual instructions.

GrylledCheez commented 1 year ago

They've been a github action for about 2 weeks now. But with the pre-commit hook, my code won't even commit locally if the --fix can't fix it automatically. There's no need to wait for the push to know it'll fail.

Either way, those are worded as "highly suggested".

Before you bring it up, almost all of my lint fails are from merge conflicts. :D

GrylledCheez commented 1 year ago

Now that I think about it, I'm not sure if you can see the actions. I get nasty emails when a run fails. https://github.com/Fmstrat/wintile/actions