Closed Fmstrat closed 1 year ago
Did you want to merely patch a v11.1 directly into master real quick? I'm out with the family at the moment. We can cherrypick into develop it after it gets accepted.
Or we can put it into what we have right now with v12. I only changed some code around and added the gaps option.
For the 2nd one, I suggest doing the version check and defining it dynamically.
partially done with this. I should be done in about 1 or 2 hours and then I'll send it off to @phavekes to check on his gnome 3 system
@Fmstrat, do you think they'll have a problem because we didn't deprecate < 20.04? (< 3.36)
Just close this when it's submitted.
After re-reading the requirements, I'm closing this in favor of #140
@GrylledCheez so close. We will need to be careful with number 2 to make sure we keep 3.36 and only remove before so we don't break Ubuntu 20.04. v11 rejections:
[x] 1. Rejected because
disable
won't getting called in prefs.js (line 36).Just create
gsettings
insidebuildPrefsWidget
and;attach it to the prefs widget to avoid garbage collecting before window close:
[x] 2. You can remove older than 3.36 and
use
ExtensionUtils.getSettings()
instead of line 1188-1190 (extension.js), 22-30 (prefs.js).