Closed GrylledCheez closed 1 year ago
@phavekes, what do you think?
@Fmstrat, I just added some cool new features. Let me know what you think.
@Fmstrat, can you at least give the :eyes: to let me know you've seen it?
@GrylledCheez I've tested the latest develop, but moving the windows with super-arrows breaks for me. This was working fine prior to this PR. Last tested commit with working super-arrows was 311fc16677b6b3a5d82cfb4840bd7584caa1b070, I did not test when it broke
How is it broken?
How is it broken?
The windows do not move if I press super+arrow. Only If i first use the mouse to move a window to a corner the super-arrow moves the window. Starting from another position, the windows do not move
Get some debug logs around the bad behavior. If you can, do a bisect and find out what went bad.
journalctl -qf | grep -i -e wintile -e 'js error'
jul 10 10:07:54 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:07:54 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left ctrl: false
jul 10 10:07:54 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:07:54 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:07:54 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:07:55 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:07:55 peter-laptop gnome-shell[4293]: [WinTile], sendMove) right ctrl: false
jul 10 10:07:55 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:07:55 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:07:55 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up ctrl: false
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left ctrl: false
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:07:56 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:07:57 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:07:57 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:07:57 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:07:57 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:07:57 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:01 peter-laptop gnome-shell[4293]: [WinTile], isResize) mask: 1 resize: false
jul 10 10:08:01 peter-laptop gnome-shell[4293]: [WinTile], windowGrabBegin) mouse - mouseX:818 mouseY:96
jul 10 10:08:01 peter-laptop gnome-shell[4293]: [WinTile], windowGrabBegin) window - x:309 y:88 w:1532 h:892
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid)
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) isNotUltrawide: true
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) mouse - mouseX:441 mouseY:0 mask:256
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) keys - ctrl:0 superPressed:0
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) monitor - x:0 y:0 w:1920 h:1080 inB:true
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) space - x:38 y:27 w:1882 h:1053
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) window - x:-68 y:27 w:1532 h:892
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid)
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) isNotUltrawide: true
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) mouse - mouseX:378 mouseY:17 mask:256
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) keys - ctrl:0 superPressed:0
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) monitor - x:0 y:0 w:1920 h:1080 inB:true
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) space - x:38 y:27 w:1882 h:1053
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid) window - x:-131 y:27 w:1532 h:892
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], windowGrabEnd)
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], initApp) init as normal
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], initApp) app.wintile: {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":-1,"col":-1,"height":-1,"width":-1}
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], moveApp) {"row":0,"col":0,"height":1,"width":1,"mouse":true}
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], moveApp) isNotUltrawide: true
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (38,27), size (941,526) with 0px gaps
jul 10 10:08:02 peter-laptop gnome-shell[4293]: [WinTile], moveApp) window.x: 38 window.y: 27 window.width: 941 window.height: 526
jul 10 10:08:03 peter-laptop gnome-shell[4293]: [WinTile], checkIfNearGrid)
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], sendMove) right ctrl: false
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Already in a tile.
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":0,"col":0,"height":1,"width":1}
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], sendMove) right
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], sendMove) right - move
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], moveApp) {"row":0,"col":1,"height":1,"width":1}
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], moveApp) isNotUltrawide: true
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (979,27), size (941,526) with 0px gaps
jul 10 10:08:04 peter-laptop gnome-shell[4293]: [WinTile], moveApp) window.x: 979 window.y: 27 window.width: 941 window.height: 526
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Already in a tile.
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":0,"col":1,"height":1,"width":1}
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down - move
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveApp) {"row":1,"col":1,"height":1,"width":1}
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveApp) isNotUltrawide: true
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (979,553), size (941,526) with 0px gaps
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveApp) window.x: 979 window.y: 553 window.width: 941 window.height: 526
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left ctrl: false
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Already in a tile.
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":1,"col":1,"height":1,"width":1}
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left - move
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveApp) {"row":1,"col":0,"height":1,"width":1}
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveApp) isNotUltrawide: true
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (38,553), size (941,526) with 0px gaps
jul 10 10:08:05 peter-laptop gnome-shell[4293]: [WinTile], moveApp) window.x: 38 window.y: 553 window.width: 941 window.height: 526
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up ctrl: false
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Already in a tile.
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":1,"col":0,"height":1,"width":1}
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up - move
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], moveApp) {"row":0,"col":0,"height":1,"width":1}
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], moveApp) isNotUltrawide: true
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (38,27), size (941,526) with 0px gaps
jul 10 10:08:07 peter-laptop gnome-shell[4293]: [WinTile], moveApp) window.x: 38 window.y: 27 window.width: 941 window.height: 526
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up ctrl: false
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Already in a tile.
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":0,"col":0,"height":1,"width":1}
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up - top up
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveApp) {"row":0,"col":0,"height":2,"width":2}
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveApp) isNotUltrawide: true
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (38,27), size (1882,1052) with 0px gaps
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveApp) maximize
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (38,27), size (1882,1052) with 0px gaps
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveApp) window.x: 38 window.y: 27 window.width: 1882 window.height: 1053
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Already in a tile.
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":0,"col":0,"height":2,"width":2}
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down - restore
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], restoreApp) move: true
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], restoreApp) app.wintile: {"origFrame":{"x":-131,"y":27,"width":1532,"height":892},"row":0,"col":0,"height":2,"width":2}
jul 10 10:08:09 peter-laptop gnome-shell[4293]: [WinTile], moveAppCoordinates) Moving window to (-131,27), size (1532,892) with 0px gaps
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) right ctrl: false
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:10 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left ctrl: false
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left ctrl: false
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:11 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) up ctrl: false
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) left ctrl: false
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], ---
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) down ctrl: false
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) isNotUltrawide: true
jul 10 10:08:12 peter-laptop gnome-shell[4293]: [WinTile], sendMove) Not in tile.
Are you able to drag and hold ctrl the release click?
Dragging works fine, but a non-tiled window can not be sent to a tile position with keyboard only anymore. The logs show [WinTile], sendMove) Not in tile.
at that moment
confirmed that this affects rows and columns of 2 on standard screens. I'll track it down
@phavekes, thanks for finding that. check b2dc121
please check off these things as they work
@phavekes, next time do you think you could look at requests on Friday or Saturday?
That way I have time to fix them before I go to bed on Sunday.
<ctrl>
+<Super>
+<Arrow>
will grow in that direction of there's room<CTRL>
and<SUPER>
to create a start point for a preview. Now you can drag a window to be X cols wide by Y rows tallbuild.sh
to only include necessary files for EGO