Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Portrait mode displays not supported #160

Closed skewty closed 1 year ago

skewty commented 1 year ago

My 4k in portrait mode does not appear to be properly supported. I cannot, for example, get the target coloring to appear anywhere on the bottom.

My display configuration is:

I am expecting my primary to be detected as an ultra-wide and my 4k to be detected as a non-ultra-wide.

My configuration is as follows:

GrylledCheez commented 1 year ago

I think I see the issue. My current calculation for if it's an ultrawide is checking of width/height is greater than 1.9

If it's in portrait mode, how many rows/columns MAX do you think it should have?

GrylledCheez commented 1 year ago

@skewty, are you able to drop tiles with ctrl+drag and ctrl+super+drag?

skewty commented 1 year ago

On the primary landscape monitor everything works. On the portrait monitor I can drop tiles using Ctrl or Ctrl-Super - MouseDrag only on the physical upper half. The physical lower half doesn't give drag targets.

Portrait mode should use the same max / mins as a regular monitor, just swap the column and row values. Personally, I will want 2 rows and 1 column on my portrait secondary monitor.

GrylledCheez commented 1 year ago

I'll work on it this weekend.

  1. allow 1 column for regular and UW
  2. check to see if the height is taller than the width and swap as necessary
  3. During testing, make sure to have screen 150%
GrylledCheez commented 1 year ago

@skewty, can you also give us some debug logs when you try to make it work?

skewty commented 1 year ago

Here is a log. I tried to get a window to go to the bottom half of my portrait monitor but it didn't work. I placed it on the top after giving up.

wintile.log

skewty commented 1 year ago

NOTE: I wont be around / able to do any more testing for around 7 days.

GrylledCheez commented 1 year ago

added in 0ee1d4c

skewty commented 1 year ago

I can now use the bottom half of my portrait monitor. Thanks!

GrylledCheez commented 1 year ago

Does everything else work too?

skewty commented 1 year ago

Actually, no. I have been noticing both Gnome Terminal and Gnome Files don't seem to size themselves correctly on my Primary ultrawide in landscape in the top right corner (perhaps other places too). The coloured zone area looks correct in size but when the window sizes itself to the zone it is often smaller or larger than the zone.

Here is a screenshot of both of them in their wrong size snapped into the same zone.

Screenshot from 2023-07-28 18-01-40

skewty commented 1 year ago

My primary is configured as 3x2. Look what just happened during testing. Another example of failed sizing. Screenshot from 2023-07-28 18-05-27

In this example you can see that the height of terminal in the middle is wrong. (It should be the same as Files).

GrylledCheez commented 1 year ago

Weird. Give us the logs for that and I'll get to it later. Is it just for gnome apps?

skewty commented 1 year ago

Don't know if it is only Gnome Apps but I chose them since they would be easy for developers to test with as well.

skewty commented 1 year ago

The problem goes away in legacy X11 mode on my system. It only seems to occur in modern Wayland session. I was able to get non Gnome app to size properly in the upper right corner in Wayland but Files seems to not size correctly most reliably so is great for testing.

skewty commented 1 year ago

G-Tile seems to be able to size windows reliably. Perhaps they are doing something extra or different than WinTile? Might be worth a look.

GrylledCheez commented 1 year ago

I'll open that as a new issue.