search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Support for G45 version #165

Closed gilvbp closed 6 months ago

gilvbp commented 1 year ago

Hi, could you update to G45 version? This tutorial might help: https://gitlab.gnome.org/ewlsh/gjs-guide/-/blob/d4cb8a9fbdf669c791dc24bc1b052e404779157b/docs/extensions/upgrading/gnome-shell-45.md Thanks.

GrylledCheez commented 1 year ago

That one will take a bit of work, but I'm not against doing it. I don't want bother if @fmstrat doesn't check back within the next 2 weeks or so, and I'll just assume he's abandoned the project.

gilvbp commented 1 year ago

If you need help, I could help with some code. Here's the official link. https://gjs.guide/extensions/upgrading/gnome-shell-45.html#esm Best regards.

PS: Here it's a link that an extension that´s already working on G45 https://github.com/ionutbortis/gnome-bedtime-mode/tree/gnome45

GrylledCheez commented 1 year ago

If you'd like to make a pull-request, aim it at the develop branch and I'll thumb through it.

gilvbp commented 1 year ago

@GrylledCheez Hi, Could you create a gnome45 branch? I'll PR there. Thanks.

GrylledCheez commented 1 year ago

The gnome-45 branch has been created. Make sure to follow the style guide in CONTRIBUTING.md

Bear in mind that at a minimum, you'll need to update: extension.js keybindings.js metadata.json

GrylledCheez commented 1 year ago

@gilvbp, while you're updating it, instead of using keybindings.js, change it to Main.wm.addKeybinding()

Mouwrice commented 10 months ago

Hi, I just updated to Gnome 45 but I see that migrating this extension to the module system appears to have halted. Are there any plans to continue development or should I look for other similar extension?

GrylledCheez commented 10 months ago

Does the Gnome-45 branch work for you? (other than the preferences window)

Fmstrat commented 10 months ago

My move is almost complete as well, so I'm back to checking on on projects every now and again.

Mouwrice commented 10 months ago

Hi @GrylledCheez

The version from this PR works for me: https://github.com/Fmstrat/wintile/pull/166 Would be nice if this gets merged!

GrylledCheez commented 10 months ago

@Mouwrice, does the prefs window work in that PR?

We can't exactly do a merge because that will make the extension stop working for any non-45 users. So we'll need to do something in the build process.

skewty commented 10 months ago

Perhaps maintain two branches or set "shell-version": ["45"] in metadata.json and move on.

GrylledCheez commented 10 months ago

@skewty, there's more to it than just changing the version in metadata.js

The entire import system changed so they're incompatible. My current thought is:

  1. write the lines for both sets
  2. Add a comment to the end of non-45 lines
  3. Comment the beginning of 45 lines with something specific
  4. build.sh will remove some lines and uncomment the others
lamarios commented 10 months ago

The import system is not compatible but if you just set the shell-version to 45 in the metadata,json older versions of gnome won't be able to install it unless they force it (there's a dconf settings for that i believe).

That's why i agree with @skewty. Keeping a legacy < 45 branch for bug fixes and keep the main branch on 45 only makes sense.

I have a small extension that I maintain and it's exactly what I did.

GrylledCheez commented 10 months ago

@gilvbp, I updated the develop branch to use Adw for prefs. Can you see if that will run on your 45 branch (make sure you swap the import lines).

Mouwrice commented 10 months ago

@Mouwrice, does the prefs window work in that PR?

We can't exactly do a merge because that will make the extension stop working for any non-45 users. So we'll need to do something in the build process.

@GrylledCheez ow, sorry for the late reply. The prefs window did indeed not work. I do not know if it does with your new changes.

But I have moved on from Gnome to Hyprland, as I have been plagued by tremendous performance issues. (https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6221) So I lost any interest and confidence in Gnome :disappointed:

gilvbp commented 10 months ago

@gilvbp, I updated the develop branch to use Adw for prefs. Can you see if that will run on your 45 branch (make sure you swap the import lines).

I'm not using Linux anymore, it doesn't have Teams 2.0 support and I use 2 accounts for my work. Because of that, I can't test :(

TimeLincoln commented 9 months ago

Very interested to see gnome 45 support for this extension. gnome 45 branch working for me for now (minus preferences window), also not maximizing when touching the center of the top panel, but works on my second monitor when i hit top center of the screen with no panel.

GrylledCheez commented 6 months ago

fixed in #179