search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Update to Gnome45 #166

Closed gilvbp closed 7 months ago

gilvbp commented 12 months ago

Update to Gnome45. TO-DO on prefs.js needs to update the widget with the new adw.PreferencesGroup layout attributes

GrylledCheez commented 12 months ago

@gilvbp, do we need keybindings.js at all?

And eslint is complaining about your use of import and export. But that might just be that we need a newer eslintrc.yml

gilvbp commented 12 months ago

@gilvbp, do we need keybindings.js at all?

And eslint is complaining about your use of import and export. But that might just be that we need a newer eslintrc.yml

Yes, we need. We have to change the eslintrc.yml to accept new ecma import type.

GrylledCheez commented 12 months ago

@gilvbp, use the latest .eslintrc.yml I pushed to your repo, then run eslint with --fix as described in CONTRIBUTING.md

GrylledCheez commented 12 months ago

That fixes the style issues!

I don't have anything with Gnome 45 right now. So just do the following checks and I'll sign off on the PR.

Perform these tests in both landscape and portrait

gilvbp commented 12 months ago

That fixes the style issues!

I don't have anything with Gnome 45 right now. So just do the following checks and I'll sign off on the PR.

Perform these tests in both landscape and portrait

  • [ ] keyboard moving
  • [ ] mouse moving around edges
  • [ ] ctrl+click and drag/drop
  • [ ] click drag, then ctrl+super and drag/drop
  • [ ] crtl+super arrow to grow in that direction
  • [ ] 1-5 rows
  • [ ] 1-5 columns

I won't be able to test the last 2 tests because pref.js still doesn't work (I described it on PR request). I need help with that. Could you use boxes with the gnome-os nightly iso version?

GrylledCheez commented 12 months ago

If you want, I'll accept this partial PR while you try and get this working. But we aren't going to release until the prefs.js works,

But here's the preferences guide for 45. https://gjs.guide/extensions/development/preferences.html#gsettings

gilvbp commented 12 months ago

Please accept this partial PR. I need to get pref.js working to release it. Thanks for the link, but I already read G45 preferences. In that link:

"The user interface will be created with GTK4 and Adwaita, which has many elements specifically for settings and configuration."#

The problem is that the new gtk4 widget changed a lot of layout attributes, as you can see here (https://docs.gtk.org/gtk4/class.Widget.html) and here: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.PreferencesGroup.html) So, we will have a lot of refactoring.

GrylledCheez commented 12 months ago

Great work. I'll see what I can learn this weekend. Make sure you update the README to say that this is only for 45, and to give yourself credit.

atassis commented 8 months ago

Hi there. I am a typescript developer and can help with this PR if needed. Migrated to latest fedora with gnome 45 and without this extension it doesnt feel good to use it. So I can both test or do smth else. Tried to write a new PR by myself but it is not that comfortable to debug what is wrong with extension changes

GrylledCheez commented 8 months ago

@atassis, take a look at some of the groundwork I started in the develop branch instead of this PR.