search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

fix issues with mutter reverting window to previous size on wayland #75

Closed lamarios closed 1 year ago

lamarios commented 2 years ago

fixes #74

lamarios commented 2 years ago

Actually, this doesn't work for GTK4 apps.

Fmstrat commented 1 year ago

@lamarios Can you provide a description of how to test this prior to merge?

GrylledCheez commented 1 year ago

@Fmstrat, how to reproduce bad behavior.

  1. open an application
  2. snap it to any predefined wintile area
  3. try to resize from any corner/edge
  4. watch the window jump oddly

Expected behavior is that height or width be maintained depending on if x or y is changing.

phavekes commented 1 year ago

I think I have reproduced your issue. Can you confirm this is what you are describing? Screencast from 2023-04-25 10-59-27.webm

GrylledCheez commented 1 year ago

That's the issue perfectly

phavekes commented 1 year ago

I've tested you changes on GNOME Shell 43.1 but it doesn't solve the window-jumping for me.

GrylledCheez commented 1 year ago

@phavekes, I was mistaken. This is a whole new problem. I'll open a new issue and I'll use your screencast if you don't mind.

GrylledCheez commented 1 year ago

@lamarios, can you resolve this conflict yourself? I'd rather not push to your master branch.

lamarios commented 1 year ago

let me see, I haven't used this extension in a long time :)

lamarios commented 1 year ago

Ok, done, not sure if this is still a necessary work around as the linked issue has been closed

GrylledCheez commented 1 year ago

Please grab the latest version v10 and let us know

lamarios commented 1 year ago

Looks like it's working as expected without my PR on gnome 44. My still be necessary for older versions, I'll close first.