Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Support gnome 44 #94

Closed jumpyvi closed 1 year ago

jumpyvi commented 1 year ago

Gnome 44 should be supported. I get GSettings schema org.gnome.shell.overrides not found as an error.

Gnome 44.0 on opensuse TW

zeropoint46 commented 1 year ago

I fixed this by updating metadata.json and adding "44.0" into the shell-version array. Then I had to edit extension.js and comment out line 871, 882, 918 and 925. Those didn't work for me on Fedora 38/Gnome 44, guess they are deprecated, not sure why but I didn't spend much time looking into it once it worked. Hope that help.

Here are the lines I commented:

   871  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   882  //              shellSettings.set_boolean("edge-tiling", false);
   918  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   925  //              shellSettings.reset("edge-tiling");
Fmstrat commented 1 year ago

Thanks, I will take a look this weekend. I also hope to add Wayland support as I do.

zeropoint46 commented 1 year ago

sound good, thanks. Not sure I understand your wayland comment, however I'm currently running Gnome on wayland natively and wintile is working with those fixes.

zeropoint46 commented 1 year ago

@Fmstrat thanks for pushing a new release, I really appreciate it and the work you did. However, it seems that version 44 is missing in the metadata.json. So I think technically the latest release you just pushed still doesn't support gnome 44.

Fmstrat commented 1 year ago

@zeropoint46 Doh. v9 incoming.

Fmstrat commented 1 year ago

@zeropoint46 if you have problems with the error above still, let me know. I don't have 44 installed so can't validate that other PRs correct and/or interfere. If there is still an issue, I'll take a look at it personally afterwards. Thanks!

jumpyvi commented 1 year ago

if you have problems with the error above still, let me know. I don't have 44 installed so can't validate that other PRs correct and/or interfere. If there is still an issue, I'll take a look at it personally afterwards. Thanks!

The same problem occurs on V9, GSettings schema org.gnome.shell.overrides not found. (Fedora 38)

Fmstrat commented 1 year ago

Reopening.

GrylledCheez commented 1 year ago

Can we not just use greater than?

const Config = imports.misc.config;
const [major, minor] = Config.PACKAGE_VERSION.split('.').map(s => Number(s));
major >= 40
c0state commented 1 year ago

The same problem occurs on V9, GSettings schema org.gnome.shell.overrides not found. (Fedora 38)

~Tiling assistant seems to have the same issue. They added a guard here it looks like? https://salsa.debian.org/gnome-team/shell-extensions/gnome-shell-extension-tiling-assistant/-/compare/a762ec1ae84f174a3802e8d216d88d4f700f97a2...debian%2Fmain?from_project_id=64661&straight=false#6961099c5b4fb26eb6d87d27b0123a002ae596be_0_164~

~Not familiar enough with gnome-shell, but removing the 4 lines referencing shellSettings (https://github.com/Fmstrat/wintile/blob/master/extension.js#L885) in my local Ubuntu 23.04 install (GNOME Shell 44.0) seems to work.~

edit: just realized https://github.com/Fmstrat/wintile/issues/94#issuecomment-1491153005 was saying basically the same thing

SOSANA commented 1 year ago

I fixed this by updating metadata.json and adding "44.0" into the shell-version array. Then I had to edit extension.js and comment out line 871, 882, 918 and 925. Those didn't work for me on Fedora 38/Gnome 44, guess they are deprecated, not sure why but I didn't spend much time looking into it once it worked. Hope that help.

Here are the lines I commented:

   871  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   882  //              shellSettings.set_boolean("edge-tiling", false);
   918  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   925  //              shellSettings.reset("edge-tiling");

I have both Ubuntu 23.04 and fedora dual boot installed both having issues. I'm about to try your recommendations on Ubuntu first. But as of right now no way to get same suggested changes to work on fedora 38?

Also curious why this project isn't maintained as this is my favorite extension and been using it forever. Will they not allow others to do pull request or hand out off to someone who will maintain this?

zeropoint46 commented 1 year ago

@SOSANA not sure what you mean by:

"But as of right now no way to get same suggested changes to work on fedora 38?".

I have commented those lines and I'm on F38 with Gnome 44 and its working just fine for me.

SOSANA commented 1 year ago

@SOSANA not sure what you mean by:

"But as of right now no way to get same suggested changes to work on fedora 38?".

I have commented those lines and I'm on F38 with Gnome 44 and its working just fine for me.

I missed read what you wrote, thought you were saying that it worked on ubuntu gnome 44 but not fedora 38 gnome 44 for some reason. Thanks for the clarification

zeropoint46 commented 1 year ago

@SOSANA not sure why, I didn't mention ubuntu at all, as I don't use it, but glad you got it now.

SOSANA commented 1 year ago

@SOSANA not sure why, I didn't mention ubuntu at all, as I don't use it, but glad you got it now.

was able to get the extention to come back but all the hotkeys are messed now. Any suggestions on how I could get the existing hot keys to work?

zeropoint46 commented 1 year ago

@SOSANA sorry I'm not sure whats going on. after I made those changes it just worked as before.

Fmstrat commented 1 year ago

It's maintained somewhat by a few people, but the problem is even with those corrections there's some rejections from GNOME for submission due to deprecated calls. I need to do some cleanup and have been unable to spend the time, hopefully soon.

SOSANA commented 1 year ago

@SOSANA sorry I'm not sure whats going on. after I made those changes it just worked as before.

I copied the folder into another directory and removed it using the extensions manager. I re-added original folder with your suggestions that I applied, and logged out and then back in again and it worked as expected.

@zeropoint46 Thank you good sir! You mind if I added you as a friend on discord? Cheers 🍻