Krd ed2 variable info update

FoRTExperiment / ed4forte

ED2 materials related to the FoRTE project

Other

4 stars 0 forks source link

Closed kdorheim closed 4 years ago

kdorheim commented 4 years ago

@ashiklom this PR does two things

Adds an indicator column to the info table about which df it is reported it
Adds an argument to run_ed that prompts users to see if they want to overwrite an existing ed output dir or not

ashiklom commented 4 years ago

Changes to run_ed look great. But I don't understand https://github.com/FoRTExperiment/ed4forte/pull/2/commits/551df2850ebe732350c875a34fdd058519cb9ad6. Looks like that just adds a inst/monthly-output.rds file, which isn't used anywhere...? I have no problem adding test output to the package, and that file is tiny anyway...but I don't think that actually accomplishes what you're after?

kdorheim commented 4 years ago

Ah shoot! good catch on 551df28 I had made some changes to the ed2_variable_info() but must have screwed up the committ