review vignettes

[atkinsjeff]

@kdorheim @bpbond can you do a check on the belowground vignette and see how it works? the inventory one is also not showing up. I have another vignette on my local that won't push for some reason...even though BASH says everything is clean and up-to-date. Kind of at a loss.

[atkinsjeff]

All seems to be working now, who knows.

[bpbond]

@stephpenn1 Do you have time to take a look at this vignette and give Jeff feedback? (I am mostly on vacation this week.)

[atkinsjeff]

Thanks @stephpenn1 anything that you see needs help or expansion here as well: https://fortexperiment.github.io/fortedata/

[stephpenn1]

Yes, I'm relatively new to vignettes but maybe I'm a good test case in that sense. I'll take a look and let you know.

[stephpenn1]

Hey @atkinsjeff Im having trouble viewing them via the vignette function... I've built the package and made sure im on the vignettes branch. Am I missing something?

[bpbond]

@atkinsjeff ? I've had trouble with this too.

[kdorheim]

Sorry for showing up late... is this issue still relevant? it is marked as closed. Is there anything I need to do?

[atkinsjeff]

Let me run this and check.

On Thu, Jul 30, 2020 at 2:30 PM Kalyn R. Dorheim notifications@github.com wrote:

Sorry for showing up late... is this issue still relevant? it is marked as closed. Is there anything I need to do?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FoRTExperiment/fortedata/issues/50#issuecomment-666585254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7XVVNPRPOXVYURP5COTOTR6G337ANCNFSM4O6Q4MEA .

-- Jeff Atkins, PhD Post-Doctoral Fellow Department of Biology Virginia Commonwealth University atkinsjeff.github.io he/his/him

[atkinsjeff]

They seem to build just fine, they show up, and then browseVignettes() brings up nothing. Very strange.

On Fri, Jul 31, 2020 at 12:05 PM Jeff Atkins jwatkins6@vcu.edu wrote:

Let me run this and check.

On Thu, Jul 30, 2020 at 2:30 PM Kalyn R. Dorheim notifications@github.com wrote:

Sorry for showing up late... is this issue still relevant? it is marked as closed. Is there anything I need to do?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FoRTExperiment/fortedata/issues/50#issuecomment-666585254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7XVVNPRPOXVYURP5COTOTR6G337ANCNFSM4O6Q4MEA .

-- Jeff Atkins, PhD Post-Doctoral Fellow Department of Biology Virginia Commonwealth University atkinsjeff.github.io he/his/him

-- Jeff Atkins, PhD Post-Doctoral Fellow Department of Biology Virginia Commonwealth University atkinsjeff.github.io he/his/him

[atkinsjeff]

If I run devtools::install(build_vignettes = TRUE) everything goes peachy keen.

[stephpenn1]

Ah, that's what I was missing!

[stephpenn1]

They look great. There's one typo in the leaf phys vignette and maybe some plot formatting issues in the project overview one but they are awesome.