mgrigri1 commented 3 years ago

Hey Team! Making a final push to get all the aboveground data and vignette up to date. I ran the check package on my local machine and fixed all the errors outside of the CMD checks, but could use some help with those. I imagine this still is less than perfect, but hoping it's an easier merge than the last couple!

codecov-commenter commented 3 years ago

Codecov Report

Merging #85 (bf3c71e) into master (432d6ad) will increase coverage by 0.84%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   79.61%   80.45%   +0.84%     
==========================================
  Files          11       11              
  Lines         417      435      +18     
==========================================
+ Hits          332      350      +18     
  Misses         85       85

Impacted Files	Coverage Δ
R/fd_inventory.R	`84.94% <100.00%> (+3.61%)`	:arrow_up:
R/fd_observations.R	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 432d6ad...bf3c71e. Read the comment docs.

mgrigri1 commented 3 years ago

alright, should be good to go other than this pesky R-CMD-check failure

bpbond commented 3 years ago

I don't know why it's segfaulting in that one test, but am going to assume it's a not-our-problem kind of thing.

FoRTExperiment / fortedata

Bringing Aboveground Data Up-to-Date #85

Codecov Report