FoUStep / ha-pan-customintegration

A custom firewall integration for Home Assistant.
1 stars 0 forks source link

Make addon compatible with hacs #1

Open Kilowatt-W opened 1 month ago

Kilowatt-W commented 1 month ago

Hi there,

thank you for the integration :-)

Maybe it would be possible to add a hacs-compatible manifest so we can download and update directly in hacs ? Should be no problem :-)

I found https://github.com/ImJustJosh/palo_alto/tree/main/palo_alto for tracking devices with the arp table, maybe it would be possible to include this script into your integration ?

Greetings from austria

Kilowatt

FoUStep commented 1 month ago

Good suggestion @Kilowatt-W, I will have to check the following items:

Kilowatt-W commented 1 month ago

Hi I think this is the right link : https://www.hacs.xyz/docs/publish/integration/ and an example at https://github.com/ludeeus/integration_blueprint

in root you need a file called hacs.json

{ "name": "PaloAlto FW Custom Integration", "render_readme": true, "hide_default_branch": true, "homeassistant": "2024.6.0", "content_in_root": true }

maybe this can help.

In hacs it will be added to user repositories :-)

FoUStep commented 1 month ago

In hacs it will be added to user repositories :-)

Not sure but I doubt HACS is scanning github for such files in order to add them to their repository? Do I have to sign up my repository anywhere? Not really clear. My apologies for being a first timer on this one.

As for your other request, tracking devices through the arp table. I will have to check and use filters using the API with this: /api/?type=op&cmd=<show><arp>all</arp></show>

Edit: I've managed to add this repo to HACS using: https://github.com/FoUStep/ha-pan-customintegration

Example: PA Repo added through HACS

It still needs a cool icon from PANW, but I believe this has to be done through Brands. I'm not sure how it works (creating branches etc).

Kilowatt-W commented 1 month ago

Hi

wonderful, really nice done. I think you don't need the brands thing becaue the integration is only listed in hacs and configured with yaml, so we don't see it in the HA integration list.

Thx. Kilowatt

FoUStep commented 1 month ago

You are welcome! I would like have to have a cool PAWN icon in front of the integration when you look at HACS.

I will try to work on your other request somewhere this week.

FoUStep commented 1 month ago

I found https://github.com/ImJustJosh/palo_alto/tree/main/palo_alto for tracking devices with the arp table, maybe it would be possible to include this script into your integration ?

@Kilowatt-W, do you have a visual (picture/screenshot/result) example of his script?

I currently have this a complete result: https://<panos-ip>/api/?key=<apikey>&type=op&cmd=<show><arp><entry name = 'all'/></arp></show> from the browser using an API call. It uses xpath, so I'll need to figure out how to get request this and use the output in a useful form.