Support ServerSideEncryption

[khaliqgant]

At the moment it looks like the upload function is used but does't accept an option to pass in the ServerSideEncryption header. The upload function takes the same params as the the putObject function:

s3.putObject({
        Bucket: bucketName,
        Key: key,
        Body: fileStream,
        ServerSideEncryption: 'AES256',
        Metadata: { 'docId': 'DOCID', 'docKey': 'XYZZY', 'index': 'pdf' }
})

Reference for the above

It would be great if the disk.write updated usage could look like this:

 await this.disk.write(path, file.buffer, {
      name,
      ServerSideEncryption: 'AES256'
 });

FoalTS is fantastic btw, awesome work!

[khaliqgant]

Hi @LoicPoullain have you had any chance to take a look at this?

Thanks!

[LoicPoullain]

FoalTS is fantastic btw, awesome work!

Thank you!

Hi @LoicPoullain have you had any chance to take a look at this?

I'm thinking of adding a fourth parameter (not the third) to the write function to pass custom options to the putObject method. This would be specific to the S3Disk service (and not Disk).

I still need to think about this to check that it won't introduce backward incompatibility, especially on the typing.

[LoicPoullain]

@khaliqgant is the ServerSideEncryption option is specific to the entire bucket or is it used only for specific files in the bucket?

[khaliqgant]

@khaliqgant is the ServerSideEncryption option is specific to the entire bucket or is it used only for specific files in the bucket?

Thanks for your attention to this! It’s a bucket wide policy

[LoicPoullain]

Ok thanks. 👍

Yes, so I think the best place to specify the option will be in the configuration then. It will allow us to keep using the generic Disk and @ValidateMultipartBody hook in this case. In this way, we will still be able to write a unique code that uses the local file system in development (for testing) and the S3 bucket in production.

[LoicPoullain]

Feature added in v2.8. Will be released this week or week-end.

[khaliqgant]

Awesome, thanks! Thanks again for your impressive work