FoalTS / foal

Full-featured Node.js framework 🚀
https://foalts.org/
MIT License
1.9k stars 142 forks source link

Revert "Move `createSession` and `readSession` to session stores" #1147

Closed LoicPoullain closed 2 years ago

LoicPoullain commented 2 years ago

Reverts FoalTS/foal#1145

codecov-commenter commented 2 years ago

Codecov Report

Merging #1147 (92e5355) into v3-0-0 (ed7102b) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           v3-0-0    #1147      +/-   ##
==========================================
- Coverage   98.86%   98.84%   -0.03%     
==========================================
  Files          98       93       -5     
  Lines        1769     1648     -121     
  Branches      420      382      -38     
==========================================
- Hits         1749     1629     -120     
+ Misses         20       19       -1     
Impacted Files Coverage Δ
packages/core/src/index.ts 0.00% <ø> (ø)
packages/core/src/sessions/core/session-store.ts 85.71% <ø> (-9.75%) :arrow_down:
...kages/core/src/sessions/http/check-user-id-type.ts 100.00% <ø> (ø)
packages/core/src/sessions/core/create-session.ts 100.00% <100.00%> (ø)
packages/core/src/sessions/core/read-session.ts 100.00% <100.00%> (ø)
...e/src/sessions/http/get-session-id-from-request.ts 100.00% <100.00%> (ø)
packages/core/src/sessions/core/index.ts
...ckages/core/src/sessions/http/use-sessions.hook.ts
packages/core/src/sessions/http/utils/index.ts
...sessions/http/utils/get-csrf-token-from-request.ts
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.