FoalTS / foal

Full-featured Node.js framework, with no complexity. 🚀 Simple and easy to use, TypeScript-based and well-documented.

https://foalts.org/

MIT License

1.88k stars 137 forks source link

Compile packages to ES2022 and not ES2021 anymore #1238

Closed LoicPoullain closed 8 months ago

LoicPoullain commented 8 months ago

Issue

Version 4 of Foal supports Node 18 and 20. We can safely compile the code to ES2022 (ES2023 is currently not supported by tsc).

Ref: https://node.green

Solution and steps

[x] Change the target fields in tsconfig.json

Checklist

[x] Add/update/check docs (code comments and docs/ folder).
[x] Add/update/check tests.
[x] Update/check the cli generators.

LoicPoullain commented 8 months ago

We get not nice compilations errors: Error: src/acceptance-test.spec.ts(161,7): error TS2612: Property 'resolvers' will overwrite the base property in 'GraphQLController'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

Closing this.