Foblex / f-flow

Foblex Flow - is an Angular library designed to simplify the creation and manipulation of dynamic flow. Provides components for flows, nodes, and connections, automating node manipulation and inter-node connections.
https://flow.foblex.com/
MIT License
96 stars 19 forks source link

Bug: WindowService doesn't exist in @foblex/core 1.2.5 and 1.2.4 #47

Closed fouad-j closed 2 months ago

fouad-j commented 2 months ago

Description

When I tried to install @foblex/f-flow on a new project, I got the following error:

✘ [ERROR] TS2305: Module '"@foblex/core"' has no exported member 'WindowService'. [plugin angular-compiler]

    node_modules/@foblex/flow/f-draggable/domain/convert-computed-to-pixels/convert-computed-to-pixels.execution.d.ts:2:9:
      2 │ import { WindowService } from '@foblex/core';
        ╵          ~~~~~~~~~~~~~

After a quick investigation, the root cause is that the @foblex/core dependency does not contain WindowService.

Is it possible to fix this, please? Also, could you please move @foblex/core to your account at https://github.com/Foblex?"

Steps to Reproduce

  1. Create new angular project
  2. Install @foblex/f-flow
  3. Start server

Expected Result

Angular server will not start because we will have compilation error

Actual Result

compilation error

✘ [ERROR] TS2305: Module '"@foblex/core"' has no exported member 'WindowService'. [plugin angular-compiler]

    node_modules/@foblex/flow/domain/update-item-and-children-layers/update-item-and-children-layers.execution.d.ts:4:9:
      4 │ import { WindowService } from '@foblex/core';
        ╵          ~~~~~~~~~~~~~

Environment Details

@foblex/flow 12.6.1 and 12.6.0

Screenshots or Videos

No response

Additional Context

No response

siarheihuzarevich commented 2 months ago

@fouad-j Thank you for bringing this issue to our attention. We’ve identified and fixed the problem with the missing WindowService in @foblex/core. To resolve the error, please reinstall @foblex/f-flow in your project:

1.  Remove the existing @foblex/flow and @foblex/core packages from your node_modules directory and package.json.
2.  Run npm install @foblex/flow to install the latest version with the fix.
alphacentauridigital commented 2 months ago

@siarheihuzarevich Thanks. It resolves the issue