search

Focus / latexer

Adds LaTex autocompletion to Atom.io
https://atom.io/packages/latexer
MIT License
20 stars 23 forks source link

Modal Panel broken with theme #68

Open hendrikbl opened 6 years ago

hendrikbl commented 6 years ago

The modal showing the citations when using \cite is broken when using some themes, e.g. atom-material-ui (it looks like this https://github.com/atom-material/atom-material-ui/issues/414).

I found that this is caused by the two classes overlay and from-top used for the select-list div. Since these clsases are already used in the parent atom-panel, it seems that they are not needed in this div. Without these classes the modal works fine with every theme.

I'm not sure if/when they changed this behaviour and if this is the right way to fix it. While it is broken in some themes, it works with others. So it could be an issue with the theme but this at least fixes it...

TheIdealis commented 6 years ago

@hendrikbl I'am glad that you found the error, or at least a quick fix. Unfortunately, I couldn't understand your explanation in atom-material-ui/#414 for how two fix the bug, i.e. which classes I have two delete in which files. Could you give me a little more detail, so that I can fix it myself, until this issue is closed?

hendrikbl commented 6 years ago

@TheIdealis You have to remove @addClass('overlay from-top cite-view') from cite-view.coffee and label-view.coffee.

TheIdealis commented 6 years ago

Works like a charm, thanks a lot!