Focus3D / crunchy

Automatically exported from code.google.com/p/crunchy
0 stars 0 forks source link

Ctrl-D makes account manager go into infinite loop (minor) #192

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1. Start the account manager
2. Press Ctrl-D
3. Avoid being hypnotised

Original issue reported on code.google.com by sjvdw...@gmail.com on 10 Apr 2009 at 8:29

GoogleCodeExporter commented 8 years ago
Thank you for the bug report.  I really like the description given for step 3.  
This
will need to be fixed before 1.0 final.

Original comment by andre.ro...@gmail.com on 10 Apr 2009 at 8:48

GoogleCodeExporter commented 8 years ago
I haven't the problem with both crunchy 1.0 alpha 1 and the version from the 
trunk.

When I press Ctrl-D, this message is printed, only one time:
>>> Please use 'exit' to exit the account manager.

I'm using Debian unstable.

But the current way to manage the CLI of the account manager is probably not 
the best
(the catching of Ctrl-D is "except EOFError,e:", maybe your OS doesn't send EOF 
with
a Ctrl-D...), and could be improved by example by using the Python cmd module
http://docs.python.org/library/cmd.html#module-cmd

If I have the time, I'll try to implement this in the next days.

Original comment by florian....@gmail.com on 10 Apr 2009 at 8:53

GoogleCodeExporter commented 8 years ago
I put the new version of the CLI for the account manager in my branch (r1052). 
Can
you try it and tell me if the issue is gone?

(The cmd module can use the GNU readline library, and should handle better 
things
like Ctr-D.)

Original comment by florian....@gmail.com on 10 Apr 2009 at 10:03

GoogleCodeExporter commented 8 years ago
Florian, your patch seems to do the job!  It now exits immediately upon Ctrl-D.

Original comment by sjvdw...@gmail.com on 12 Apr 2009 at 3:20

GoogleCodeExporter commented 8 years ago

Original comment by shadytr...@gmail.com on 12 Aug 2009 at 9:45

GoogleCodeExporter commented 8 years ago
I merged in Florian's patch into r1289. This was done by hand, so everybody 
should get 
on the patch review gravy train.

Original comment by shadytr...@gmail.com on 12 Aug 2009 at 10:38

GoogleCodeExporter commented 8 years ago

Original comment by shadytr...@gmail.com on 13 Aug 2009 at 2:51