search

Fody / PropertyChanged

Injects INotifyPropertyChanged code into properties at compile time
MIT License
1.89k stars 228 forks source link

Weaver.xml v2.0 #236

Closed dansiegel closed 7 years ago

dansiegel commented 7 years ago

After testing v2.0 noticed the following issues

1) The FodyWeavers.xml is not getting created in the netstandard library. 2) The FodyWeavers doesn't actually contain the <PropertyChanged /> node. Really would be nice to include the following:

FodyWeavers.xml.install.xdt

<?xml version="1.0" encoding="utf-8" ?>
<Weavers xmlns:xdt="http://schemas.microsoft.com/XML-Document-Transform">
  <PropertyChanged xdt:Transform="Insert"/>
</Weavers>

FodyWeavers.xml.uninstall.xdt

<?xml version="1.0" encoding="utf-8" ?>
<Weavers xmlns:xdt="http://schemas.microsoft.com/XML-Document-Transform">
  <PropertyChanged xdt:Transform="Remove" />
</Weavers>

nuspec

<file src="FodyWeavers.xml.install.xdt" target="content"/>
<file src="FodyWeavers.xml.uninstall.xdt" target="content"/>
MihaMarkic commented 7 years ago

AFAIK this is by design since NuGet doesn't allow that anymore. @SimonCropp written that somewhere. You simply create it manually.

SimonCropp commented 7 years ago

@MihaMarkic is correct. also the xml.install.xdt is fundamentally broken since it doesnt understand upgrades, so during an upgrade u delete any customizations to the node