search

Foggalong / hardcode-fixer

Fixes Hardcoded Icons
GNU General Public License v3.0
287 stars 49 forks source link

Improvement: add gitee and jsdelivr resource url #371

Closed nooop3 closed 4 years ago

nooop3 commented 4 years ago

To resolve the GitHub access issue in some regions, I added a new environment variable HARDCODE_FIXER_SOURCE, which can set to gitee and jsdelivr and default is github. Can temporarily address #369 until the fallback is added.

Foggalong commented 4 years ago

@nooop3 I like this as a temporary solution, but it doesn't close #369 since I've made that about creating an offline fallback option so that it covers wider issues of network access. It does need some more work though so that it better integrates into the script; will do a more thorough review this weekend.

nooop3 commented 4 years ago

@Foggalong Yes, you are right. This is a temporary solution. And I only added the new_date check to avoid the script error, maybe we could add another offline flag, so we can skip the upgrade check in the offline situation.

Foggalong commented 4 years ago

@nooop3 For sure, you did the right thing bumping the date! And yeah as discovered over there the plan is to add that kind of fallback :)

Foggalong commented 4 years ago

Updated your code to make those fallbacks available directly through the script rather than as env variables. Thanks so much for getting the ball rolling on this :smile: