search

Foldex / AdwSteamGtk

A simple Gtk wrapper for Adwaita-for-Steam
GNU General Public License v3.0
196 stars 5 forks source link

Add Ukrainian translation #26

Closed Vovkiv closed 1 year ago

Vovkiv commented 1 year ago

Congrats on adding i18n support!

Foldex commented 1 year ago

Thanks for the TL!

Unfortunately while most of it does work, it seems like toasts and dialogs are unaffected:

Dialog

![image](https://github.com/Foldex/AdwSteamGtk/assets/47908676/e016c253-efff-43dc-a72a-29ce3e39f645)

Toast

![image](https://github.com/Foldex/AdwSteamGtk/assets/47908676/e36733ea-5314-428b-83c8-04291b559f47)

But looking through the po shows me that they clearly are present: https://github.com/Foldex/AdwSteamGtk/blob/64b970829efeafbddeaf90d94444c7f75b9d10b5/po/uk.po#L309 https://github.com/Foldex/AdwSteamGtk/blob/64b970829efeafbddeaf90d94444c7f75b9d10b5/po/uk.po#L285

and code wise they are using gettext: https://github.com/Foldex/AdwSteamGtk/blob/321cd00713a0fe2ad30c39c2c667e0a6a6a8568c/src/main.py#L143 https://github.com/Foldex/AdwSteamGtk/blob/321cd00713a0fe2ad30c39c2c667e0a6a6a8568c/src/pages/window.py#L222

Shrug. Gonna guess the issue is probably on my end, as I'm not that familiar with gettext's nuances.

I did just add a Translators Section to the credits though, so if you can sync up your branch and add in your info I'll go ahead and merge. https://github.com/Foldex/AdwSteamGtk/blob/321cd00713a0fe2ad30c39c2c667e0a6a6a8568c/src/info.py.in#L33

Vovkiv commented 1 year ago

Yeah, i recently was translating another GTK + Adwaita program (https://gitlab.gnome.org/World/Upscaler/-/issues/24) and there was also issues with non-translated bits, despite them being clearly in po file. I think developer there still didn't catch all untranslated parts in code.