search

FoldingAtHome / containers

Docker containers for easily launching the Folding@home client anywhere!
Creative Commons Zero v1.0 Universal
62 stars 20 forks source link

Zombie processes are not cleaned up by the container #30

Open MJDSys opened 1 year ago

MJDSys commented 1 year ago

I'm using the fah-gpu-amd container to run the folding@home client on my desktop, as the OS it runs is not supported by ROCm userspace and having a consistent environment is much simpler.

I've noticed if the folding@home client kills a subprocess for some reason (pausing, or if some bug is detected), the process ends up as a zombie and the folding@home client never cleans it up. As folding@home is PID 1, there is no other reaper and the process continue to exist and the client gets wedged, unable to respawn the work unit. Note: this happens to both GPU and CPU WU on the same machine.

Could the folding@home client be updated to reap these processes? Otherwise, could the containers be updated with a different PID 1 to reap these dead children? If the new PID 1 is wanted, I could take a look at creating an appropriate PR.

skandix commented 1 year ago

I guess this can be fixed by adding --pid-file=/var/run/fahclient.pid on the entrypoint.