search

FoldingAtHome / fah-client-bastet

Folding@home client, code named Bastet
GNU General Public License v3.0
74 stars 13 forks source link

Periodic log rotation doesn't create new file #209

Closed dymil closed 9 months ago

dymil commented 9 months ago

basically what https://foldingforum.org/viewtopic.php?t=39416 reported last year. I see

Log Rotated 2024-02-05T00:00:15Z

at the bottom of log.txt (or in web control), but any new logging is just dropped on the floor until I quit and restart the client.

Yesterday I have one log ending

23:57:34:I1::WU11:Completed 312500 out of 1250000 steps (25%) Log Rotated 2024-02-04T00:00:03Z

and then the next log, hours later (presumably when I noticed and restarted) begins with WU12.

This is on Windows 10, for what it's worth. Nothing exotic about the directories involved, i.e., C:\ProgramData\FAHClient.

I poked around a bit in the cbang logging code to try to understand, but it seems like all roads lead to Logger::createStream, where the periodic rotation happens. I haven't tried building cbang myself to test, but I could imagine a Windows issue which manifests in startLogFile, since I don't see any tests for the logging.

kbernhagen commented 9 months ago

Which client version? Debug or Release?

dymil commented 9 months ago

Release, just the 8.1.18 download from https://foldingathome.org/beta/

kbernhagen commented 9 months ago

Please consider trying v8.3.1 alpha https://foldingathome.org/alpha/

jcoffland commented 9 months ago

This should already be fixed in v8.3.2.

dymil commented 9 months ago

D'oh, I didn't know about the alpha or look at the releases/commits on GitHub, such as cac9a08073e2ea6017ce1b26f2f80e940b3b8c62. I'll see with v8.3.3. ~v8.3.1 now, as I can't run v8.3.2 after a separate issue #210 arose.~

dymil commented 9 months ago

Seems fixed indeed!