Closed Hou5e closed 1 year ago
Would you be willing to submit a PR?
If the script is available, sure. It's hard to test it without a similar development environment though. I most likely can work around not having the files though.
Different versions of the NSIS compiler have issues with a couple languages listed above (and I just remove those ones from the script)
OK, I'll look into updating this: https://github.com/FoldingAtHome/fah-client-bastet/tree/master/install/win Let me know if you would like other changes besides the language addition.
It would be nice if we had a way to build PRs or forks using our build system. I could give you access to this but currently we only can only build the main branch. We are using buildbot so it is possible to set this up.
I was able to test my changes reasonably well without the build system variables being passed in (using hard-coded values), and only using the files from the existing installed location to build an installer for my testing purposes.
This pull request has the initial translation functionality implemented: https://github.com/FoldingAtHome/fah-client-bastet/pull/54
I didn't try to replace the custom page with the standard NSIS pages to get similar functionality so they will be translated. I didn't try to get and use the (~15) GPLv3 license translations from: https://www.gnu.org/licenses/translations.html Let me know if you want me to do these. I'm intending to, but probably over the weekend.
I've made the improvements for this over the past few releases including v8.1.6. This issue should be considered completed.
There was one minor issue that can be resolved on the NSIS compiler machine that is being used: NSIS compiler setup change to fix the path separators from being displayed as Yen symbols for Japanese:
In file: C:\Program Files (x86)\NSIS\Contrib\Language files\Japanese.nlf Make a backup copy, and update the original from:
# Font and size - dash (-) means default
MS Pゴシック
9
To:
# Font and size - dash (-) means default
-
-
Before (Showing the Japanese language issue with the path):
After making the compiler file change:
To test this, run the windows installer, and Japanese is the bottom entry on the language pull-down list dialog.
I'm marking this done. Open a separate issue for the Japanese language problem if you think it's important.
As long as the NSIS installer is using the boiler-plate installer pages, they will all be translated with the initial language selection box in the installer. The custom page you are using could probably be done differently to use the normal NSIS installer pages.
The only thing you need to double-check is that you have the Unicode version of the NSIS plugins installed at: C:\Program Files (x86)\NSIS\Plugins\x86-unicode (or, in the !addplugindir "plugins\x86-unicode" path)
Then the code changes are pretty easy to enable it. These are the relevant lines from a script (examples listed below)
Older example from original author: https://nsis.sourceforge.io/Examples/Modern%20UI/MultiLanguage.nsi
Related to Translations request: https://github.com/FoldingAtHome/fah-web-client-bastet/issues/39