Can't open epub because icon menu missing

FolioReader / FolioReader-Android

A Java ePub reader and parser framework for Android.

BSD 3-Clause "New" or "Revised" License

2.25k stars 718 forks source link

Can't open epub because icon menu missing #294

Closed itsvee closed 6 years ago

itsvee commented 6 years ago

Issue / Feature - When openBook called, app crash. FolioReader version - 0.4.4 FolioReader Stock / Modified - Stock Android SDK - 28 Mobile / Tablet / Emulator Info - Google Pixel 2 (mobile) Crash / Error 'android.graphics.drawable.Drawable android.view.MenuItem.getIcon()'

Steps to reproduce / Describe in detail

I setup by your step (use gradle) and run epub from R.raw. That code run in Fragment and define code in Adapter. When that Adapter run clicklistener, it had error like this

I saw FolioActivity.java and check onCreateOptionsMenu found R.id.itemConfig and R.id.itemTts was missing. How can I fix it ? Thank you

hrishikesh-kadam commented 6 years ago

@itsvee I just tried integrating FolioReader in a fresh new project. Unable to reproduce this issue.

itsvee commented 6 years ago

@hrishikesh-kadam Um... let me check again. thanks you

itsvee commented 6 years ago

Ok, I found this problem because my project had menu_main.xml in res/menu and your library had menu_main.xml too. It confuse when call menu on navigation bar. 😃

hrishikesh-kadam commented 6 years ago

@itsvee So what fix you did? Renamed your menu_main.xml?

olaolumusic commented 5 years ago

Thanks alot @itsvee , Been debugging and de-scoping various sections of my project until i tried your solution (In my case, I actually deleted my mine). I would actually recommend the one in the folioreader gets renamed to .. folio_menu_main.xml or something because its really very difficult to figure out amidst tonnes of menu items and layouts

Kind Regards.