Fix heading bug in Style.css

FolioReader / FolioReader-Android

A Java ePub reader and parser framework for Android.

BSD 3-Clause "New" or "Revised" License

2.25k stars 718 forks source link

Fix heading bug in Style.css #309

Closed yh54321 closed 5 years ago

yh54321 commented 5 years ago

Fixes bug which causes certain chapter titles to be stylized incorrectly (Compare chapter 2 to chapter 3: https://s3.amazonaws.com/moby-dick/moby-dick.epub) Affects span elements within h1-6 elements

mahavir155 commented 5 years ago

thanks @yh54321

yh54321 commented 5 years ago

I found an error in my fix, it won't work. Best thing is to revert and delete line 301 like @hrishikesh-kadam did in his repo, (unless line 301 has a purpose...), or to accept another PR I'm about to post.

hrishikesh-kadam commented 5 years ago

@yh54321 Yes, exactly. Changes in https://github.com/codetoart/FolioReader-Android/commit/07bee5abb8b11968a1599168622a9d5ca481f2f7 would be sufficient. Don't worry about breaking master branch as changes in above commit will get merge in FolioReader master for next release.

@mahavir155 We can close PR #313

yh54321 commented 5 years ago

@hrishikesh-kadam Okay, thank you