FolioReader / FolioReader-Android

A Java ePub reader and parser framework for Android.
BSD 3-Clause "New" or "Revised" License
2.25k stars 716 forks source link

compiling issue in the latest version com.folioreader:folioreader:0.5.3 #332

Closed miladmetias13 closed 5 years ago

miladmetias13 commented 5 years ago

Issue / Feature - Issue FolioReader version - 0.5.3 FolioReader Stock / Modified - Stock from gradle Android SDK - minSdkVersion 22 targetSdkVersion 28 Mobile / Tablet / Emulator Info -
Crash / Error - error

Steps to reproduce / Describe in detail -

I'm trying to use the latest version after your latest fixes and i'm having this compilation error

Manifest merger failed : Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91 is also present at [androidx.core:core:1.0.1] AndroidManifest.xml:22:18-86 value=(androidx.core.app.CoreComponentFactory). Suggestion: add 'tools:replace="android:appComponentFactory"' to element at AndroidManifest.xml:5:5-20:19 to override.

TestMyApplication.zip

hrishikesh-kadam commented 5 years ago

@miladmetias13 FolioReader has been migrated to AndroidX. Eventually, everyone will have to migrate to AndroidX sooner or later. You can read more about it here - https://developer.android.com/jetpack/androidx/