search

Foliotek / Croppie

A Javascript Image Cropper
http://foliotek.github.io/Croppie
MIT License
2.58k stars 885 forks source link

Resizer Touch events #466

Open ShaMan123 opened 6 years ago

ShaMan123 commented 6 years ago

I downloaded an instance of croppie a week ago. The touch resize events didn't work. After inspection I found that the code was missing but here I see it.

Is this new?

` if (vr) { vr.addEventListener('mousedown', mouseDown); vr.addEventListener('touchstart', mouseDown); }

    if (hr) {
        hr.addEventListener('mousedown', mouseDown);
        hr.addEventListener('touchstart', mouseDown);
    }`
atroppe commented 6 years ago

I am also struggling with this issue. I came across a pr in which these lines of code were added to the croppie library, but it does not seem to be present in the latest released version.

Any update as to which version of croppie is needed in order to support touch events?

ShaMan123 commented 6 years ago

I abandoned this library for a different solution. However, it's easy to fix.

בתאריך יום ו׳, 20 ביולי 2018, 18:18, מאת Amy Troppe ‏< notifications@github.com>:

I am also struggling with this issue. I came across a pr in which these lines of code were added to the croppie library, but it does not seem to be present in the latest released version.

Any update as to which version of croppie is needed in order to support touch events?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Foliotek/Croppie/issues/466#issuecomment-406632598, or mute the thread https://github.com/notifications/unsubscribe-auth/AgwLcdjgzX1AWc-Gk1KPZel32ht2iX8Eks5uIfS2gaJpZM4R7wGR .

atroppe commented 6 years ago

I tried editing my local copy but it did not work. I am using the angular package referenced above, so I suspect I would need the angular package to support the version released after the change was made to the croppie library.

ShaMan123 commented 6 years ago

check out my PR changed files: croppie.js croppie.css

This is an old version though. It's been a long time since I worked with it. Hope it helps. I Have no clue about angular.

CharlieScarver commented 6 years ago

I too faced this problem. I just updated to the latest version of croppie @2.6.2 and the touch event code is there and works on a tablet. 🥇