search

Foliotek / Croppie

A Javascript Image Cropper
http://foliotek.github.io/Croppie
MIT License
2.55k stars 886 forks source link

Demonstrate Real Time Cropping on Demo page #52

Open isaac-peka opened 8 years ago

isaac-peka commented 8 years ago

This is a great library, would be even better with support for chaining :)

thedustinsmith commented 8 years ago

Which methods would you like to see chained? Most of the methods return something at this point, so I don't see how we would chain.

isaac-peka commented 8 years ago

Sorry, just realised how unclear this was. I meant show the cropped changes in another div in real time. For example: http://fengyuanchen.github.io/cropper/

thedustinsmith commented 8 years ago

So you'd just like a demo that demonstrates how to do that? Or is there some functionality that's missing? I know we don't fire the update event until the dragging has completed, so the "real-time" would be missing.

isaac-peka commented 8 years ago

A demonstration would be really helpful. I think these things tend to look better when the changes tracked are live rather than have a delay for feedback - but it's definitely not essential.

thedustinsmith commented 8 years ago

I agree. At one point the demo page did have live changes, but having multiple of those got a little too busy. Maybe one wouldn't hurt.

Lenndev commented 8 years ago

Just fixed this. :) though the live result is a bit behind because you have to wait for the promise.

here is what i did: (just some html and js to show the basic setup doesnt work in fiddle cause no croppie!!!) hope this helps https://jsfiddle.net/Lenndev/9rjzgsmu/