search

Foliotek / Croppie

A Javascript Image Cropper
http://foliotek.github.io/Croppie
MIT License
2.56k stars 885 forks source link

Update _originalImageWidth & _Height #711

Open Coeur2Boeuf opened 4 years ago

Coeur2Boeuf commented 4 years ago

On rotate image, the _originalImageWidth & _originalImageHeight are not updated... So, the result was on the old value. This example, fix this issue.

webmasterMeyers commented 4 years ago

This fix works for me on v2.6.4, please merge!

michael-letcher commented 4 years ago

Fixes #699 & #668

tristanbenier commented 4 years ago

This works for me as well on v2.6.4, please merge it !

Uleertel commented 4 years ago

I tried to use this fix by using the fork from Coeur2Boeuf and it didn't work. The explanation is that on the master branch of croppie there is already a fix for it just a few lines after this fix! The fork by Coeur2Boeuf is based on the master so we have a double fix that cancel each other.... So either use the fix of Coeur2Boeuf or use the master branch but do not use both! So what we need really is a 2.7 from master. Someone knows if master is stable as it is?

andrewflon commented 3 years ago

This works for me!