Closed cwervo closed 4 months ago
Code mostly looks great. Two things:
::getColor
in Colors.tcl
, I think (maybe just name your global proc there ::getColor?)Yep, just declaring ::getColor
in Colors.tcl
works great!
Yeah, it's annoying ergonomically/might commonly trip people up. That said I'm not sure how to handle spaces in that argument, is the only option to manually make a parser to go through the /...options/
from every wishes to draw a
call site?
Yeah, I guess other alternatives to Wish this is outlined rgb([* $i 10],0,0)
are:
Wish this is outlined "rgb([* $i 10], 0, 0)"
Wish this is outlined [rgb [* $i 10] 0 0]
Neither seems like an unqualified win to me :-/
merging for now but yeah!
I've modified the Colors namespace to put all the color logic in
Colors.tcl
and support the following formats for colors:0xNNN
or0xNNNNNN
rgb(N,N,N)
hsl(N,N%,N%)
Here's a fun sample program using the new capabilities: