search

Folleach / GeometryDashAPI

API for Geometry Dash
MIT License
62 stars 8 forks source link

Edit SFX and Edit Music Object Support #31

Closed guighub closed 7 months ago

guighub commented 8 months ago

Is your feature request related to a problem? Please describe. I'm currently working on a MIDI importer for Geometry Dash that imports each note as a sound effect with a set pitch and volume, and I need a way to stop the note with an "Edit SFX" object after the MIDI note ends.

Describe the solution you'd like Edit Music and Edit SFX objects similar to the SfxTrigger() object in the current API.

Describe alternatives you've considered I tried toggling the SFX object on or off with a Toggle trigger object but I don't think it affects the sound.

Additional context No additional context that I know of.

Folleach commented 8 months ago

Thank you for request. I'll go add Edit Song Trigger (that's what it's called in the game) and Edit Sfx Trigger

I tried toggling the SFX object on or off with a Toggle trigger object but I don't think it affects the sound.

You're right, toggle trigger is just used to activate some trigger, no more

Folleach commented 8 months ago

I've done :)
EditSfxTrigger and EditSongTrigger released in v0.2.23

Your project is interesting.
I'd like to take a look at your project, when you're done, will you share it?

ascpixi commented 8 months ago

@Folleach Hi! I'm also interested in SFX trigger functionality. It seems like the SFXGroup member is missing from SfxTrigger. It is present in EditSfxTrigger, so I'm not sure if this is an oversight. Thanks in advance!

image

guighub commented 8 months ago

I've done :) EditSfxTrigger and EditSongTrigger released in v0.2.23

Your project is interesting. I'd like to take a look at your project, when you're done, will you share it?

Thank you so much! And yes, when the project is mostly complete I plan to make a repo for it.

ascpixi commented 8 months ago

@Folleach Hi! I'm also interested in SFX trigger functionality. It seems like the SFXGroup member is missing from SfxTrigger. It is present in EditSfxTrigger, so I'm not sure if this is an oversight. Thanks in advance!

I have implemented this in pull request #32. @Folleach

Folleach commented 8 months ago

@ascpixi oh... Wow. Thank you! I didn't notice that the trigger has other pages at first, hah

I've review and merge your pull request #32
Now I should add other missing properties, then I'll create a new release

Folleach commented 8 months ago

So, it seems I've added properties from all pages. You can use it in the version 0.2.24

Thank you very much! Have a good day ^_^
If you have any more questions, feel free to ask