search

Folleach / GeometryDashAPI

API for Geometry Dash
MIT License
62 stars 8 forks source link

fix for 2.2 #37

Closed flightlex closed 3 months ago

Folleach commented 4 months ago

Thank you for PR!
I'll watch it soon.

So far, I can say that two merge commits in your repository were unnecessary. They refer to the PR numbers that are made in your repository and do not make sense.
You could make separate branches for your functionality, then do PR with them in the origin repository.
Once the PR is in the main branch, you can simply pull your main branch from the origin repository.

Now, since your commit is not signed, I can make a cherry pick during the merge. Can I?

flightlex commented 4 months ago

Thank you for PR! I'll watch it soon.

So far, I can say that two merge commits in your repository were unnecessary. They refer to the PR numbers that are made in your repository and do not make sense. You could make separate branches for your functionality, then do PR with them in the origin repository. Once the PR is in the main branch, you can simply pull your main branch from the origin repository.

Now, since your commit is not signed, I can make a cherry pick during the merge. Can I?

go ahead

Folleach commented 3 months ago

I've cherry pick this commit to 1f4e91e6
Then I made some fixes, described them in the commit 24582c6b

Released in v0.2.28

GitHub doesn't match changes from origin to the pull request, so I'm closing this PR