support for linux 4.20 ?

1over137 commented 5 years ago

I am on linux 4.20(arch) and it fails to compile.

make ARCH=x86_64 CROSS_COMPILE= -C /lib/modules/4.20.5-arch1-1-ARCH/build M=/home/zandimna/Downloads/rtl8822bu modules
make[1]: Entering directory '/usr/lib/modules/4.20.5-arch1-1-ARCH/build'
  CC [M]  /home/zandimna/Downloads/rtl8822bu/os_dep/linux/os_intfs.o
In file included from /home/zandimna/Downloads/rtl8822bu/include/drv_types.h:35,
                 from /home/zandimna/Downloads/rtl8822bu/os_dep/linux/os_intfs.c:22:
/home/zandimna/Downloads/rtl8822bu/include/wifi.h:1005: warning: "IEEE80211_MAX_AMPDU_BUF" redefined
 #define IEEE80211_MAX_AMPDU_BUF 0x40

In file included from /home/zandimna/Downloads/rtl8822bu/include/osdep_service_linux.h:84,
                 from /home/zandimna/Downloads/rtl8822bu/include/osdep_service.h:41,
                 from /home/zandimna/Downloads/rtl8822bu/include/drv_types.h:32,
                 from /home/zandimna/Downloads/rtl8822bu/os_dep/linux/os_intfs.c:22:
./include/linux/ieee80211.h:1442: note: this is the location of the previous definition
 #define IEEE80211_MAX_AMPDU_BUF  0x100

/home/zandimna/Downloads/rtl8822bu/os_dep/linux/os_intfs.c:1170:22: error: initialization of ‘u16 (*)(struct net_device *, struct sk_buff *, struct net_device *, u16 (*)(struct net_device *, struct sk_buff *, struct net_device *))’ {aka ‘short unsigned int (*)(struct net_device *, struct sk_buff *, struct net_device *, short unsigned int (*)(struct net_device *, struct sk_buff *, struct net_device *))’} from incompatible pointer type ‘u16 (*)(struct net_device *, struct sk_buff *, void *, u16 (*)(struct net_device *, struct sk_buff *, struct net_device *))’ {aka ‘short unsigned int (*)(struct net_device *, struct sk_buff *, void *, short unsigned int (*)(struct net_device *, struct sk_buff *, struct net_device *))’} [-Werror=incompatible-pointer-types]
  .ndo_select_queue = rtw_select_queue,
                      ^~~~~~~~~~~~~~~~
/home/zandimna/Downloads/rtl8822bu/os_dep/linux/os_intfs.c:1170:22: note: (near initialization for ‘rtw_netdev_ops.ndo_select_queue’)
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:292: /home/zandimna/Downloads/rtl8822bu/os_dep/linux/os_intfs.o] Error 1
make[1]: *** [Makefile:1562: _module_/home/zandimna/Downloads/rtl8822bu] Error 2
make[1]: Leaving directory '/usr/lib/modules/4.20.5-arch1-1-ARCH/build'
make: *** [Makefile:1318: modules] Error 2

Did i do anything wrong? Thanks in advance.

FomalhautWeisszwerg commented 5 years ago

I appreciate your report. I've planned to support for Linux-4.20.

1over137 commented 5 years ago

It's been some time, any progress so far? Since 5.0 is out already too, you may as well try to support it as well (there may or may not be a need to do so though)

MatthewMeredith commented 5 years ago

Same error here, running 5.0.7

Any chance of this getting updated?

FomalhautWeisszwerg / rtl8822bu

support for linux 4.20 ? #23