search

Fonotec / PSF

PSF (Pulsar Spectral Folder): The fastest spectral folder in the local Universe
3 stars 2 forks source link

Yaml parameter file and parameter class #7

Closed Fonotec closed 6 years ago

Fonotec commented 6 years ago

I created a first draft of the parameter file and a class that reads the file. The class can be easily initialized, I didn't yet implemented it in the rest of the code. Also the class checks if different parts of the file are included, not all parts are optional so to say.

If this is implemented in the future in the code it will be a lot cleaner to run.

ewoudwempe commented 6 years ago

I changed some things and rewrote the yamlobject thing quite a bit. Now we won't have to add it to the file when we decide to add another parameter. Also I made some changes in the yml file format.

Fonotec commented 6 years ago

This looks good, currently I get an error while running the code. I get the following error: ValueError: invalid literal for int() with base 10: 'N', the problem occurs at lines 47, 48 and 50 of barcen.py. I don't exactly get what is going on.

Fonotec commented 6 years ago

Apparently this is an Astropy error, so they should fix this. On some machines this could be a problem but on most machines this error will not appear, so this can be merged. Thanks @ewoudw !