FontBureau / videoproof

Experimenting with animated proofing tools for variable fonts
Apache License 2.0
15 stars 2 forks source link

Private fonts don't work at all, and should work trivially via a cache #32

Open davelab6 opened 1 year ago

davelab6 commented 1 year ago

When I visit typeroof and drag and drop a local private font and make a comment:

http://videoproof.graphicore.de/#2022-12-06T17:03:37Z;TestFlex%20opsz18-wdth100-wght400-ROND0,Version%205.000;Test;0.0.1.0.0.5-0.0.1.0.0.6;40;;10;5;0;opsz64;1;64;0;l;;opsz25;1;25;0;l;;;1;18;0;l;;;1;18;0;l;;opsz14;1;14;0;l;;@v2:typespec

and then reload the page (in incognito) I get this error:

via VideoproofController constuctor initial resources:TypeError: this.uiStateFields is not iterable
Screenshot 2022-12-06 at 10 04 45 AM

(Note I changed the font family name since this is a public repo)

In https://github.com/Tgemayel/variable-fonts-figma Toni made a AWS Lambda service to cache drag'n'dropped fonts on a server so they could be accessed as URLs with a file md5 hash uid, and probably something similar would be important here to aid testing of private 'nightly' fonts. Entering a simple secret to access the cache would be fine to limit scale/costs of the service.

graphicore commented 1 year ago

This was closed by a commit message,re-opening for my report.

Now there's a local storage (with indexedDB) that will store all dropped fonts locally in the browser, persistent over sessions (not in private browsing).

There are also 3 new modal <dialog> widgets coming with this: