Fonta1n3 / FullyNoded

Self sovereign, secure, powerful, easy to use wallet that utilizes your own node as a backend. Powered by PSBT's and descriptors. Acts as an offline signer using your node as a watch-only wallet. C-Lightning compatible for instant, unfairly cheap payments.
https://fullynoded.app
Other
201 stars 31 forks source link

Shutting down #1

Closed luvarado closed 5 years ago

luvarado commented 5 years ago

I enter all the node information and app shuts off.

niallyoung commented 5 years ago

Same here - have tried RPC and ssh, both fail to connect and the App gets stuck stuck in a crash loop every time you open it. Need to delete and reinstall, then same issue.

Fonta1n3 commented 5 years ago

I have made some improvements to the code and it should be released in the next day or so. Please update the app when its released and try again. In the meantime if you can give me more info that'd be helpful:

Which ios version are you running?

Have you configured your ssh config file to allow password log in?

If using rpc have you put "allowip=" into your bitcoin.conf file?

niallyoung commented 5 years ago

Cheers @FontaineDenton , IOS 12.1.4 followed the setup instructions explicitly, no firewall etc. and I confirmed RPC and SSH connectivity beforehand. Looking forward to the next version hitting the App Store, will check out the source and contribute this week hopefully.

Fonta1n3 commented 5 years ago

@niallyoung the update is live. Could you please try it? If you were trying to use a custom port for SSH then that would have been an issue on the original version, new version supports custom ports.

Is Bitcoin Core running on a personal computer or server?

The least amount of things can go wrong with SSH.

If using RPC to connect you need to ensure your ports are open and you are using the correct IP address.

I have used it extensively with SSH password log in on custom port and not had any issues. Ensure you have edited your /etc/ssh/sshd_config and uncommented/added PasswordAuthentication yes and then sudo service sshd restart.

Let me know how it goes.

Fonta1n3 commented 5 years ago

@luvarado which device are you using? Are you still having an issue with the updated version?

niallyoung commented 5 years ago

Upgraded Fully Noded, latest IOS that just came out - enter IP address and Port and instant crash. After that point it crashes as soon as it unlocks, every time.

Deleted and reinstalled, started RPC setup again - enter all details, port 8332 and get the new Error screen. Click SSH and I get a spinning progress wheel - and it gets stuck there permanently.

bitcoinf.conf

rpcuser=xxx rpcpassword=xxx rpcallowip=x.x.x.x/24 server=1 rest=1 daemon=1

EDIT: I'm still trying to get Carthage to update AES256CBC to 3.2 / Swift 4.0 so I can build and test this (are you able to add build instructions to the README and/or update for Xcode 10?) but is it possible the ssh client is stuck trying to add the host key? session.addKnownHostName()?

Fonta1n3 commented 5 years ago

@niallyoung do you have FaceID enabled on your device? Do you use it to unlock the app? If so that will be causing the crash most likely as I hadn't added the necessary permissions to the info.plist file for FaceID. That is fixed in the next update.

AES256CBC and SwiftyKeyChainWrapper are both XCode 10 compatible so that shouldn't be the issue. I have not tried to side load the app myself and am not running XCode 10 myself so I am not sure.

I do not use session.addKnownHostName() in the app.

The only way the app can connect via SSH is by password log in. If you have tapped "Try SSH" then the app as will always try SSH, I have fixed this in the next update to make it an option in settings so user has control.

Thank you for your feedback and patience. Please keep me updated.

Fonta1n3 commented 5 years ago

@niallyoung

Deleted and reinstalled, started RPC setup again - enter all details, port 8332 and get the new Error screen. Click SSH and I get a spinning progress wheel - and it gets stuck there permanently.

Is your node public? Does it have incoming connections? Unless you explicitly edit your SSH config file to allow password log in it SSH will not work.

If you specify an IP in rpcallowip=x.x.x.x/24 then your iPhone must be using that IP in order to log in via RPC.

Also you are specifying port 24 so you'd need to try and connect via port 24 if using RPC, not 8332. Have you tried that?

niallyoung commented 5 years ago

Yep node is public, has incoming connections - has worked for years. sshd config allows password - I've tested both RPC and SSH connectivity prior to using the App. I'm not side-loading but using the App Store build, was just looking at the source to try and replicate and provide a pull request.

rpcallowip "/24" is a netmask, not a port.

iPhone8, no FaceID but I have used both FN Password and TouchID - once logged in fine I consistently get the Error screen when RPC connections fails, and then when SSH attempts to connect just a progress spinner forever.

niallyoung commented 5 years ago

UX isn't great - once RPC credentials are saved, if I want to try RPC again I have to re-enter all of them again. Suggest you split Renew into two separate workflows - renew credentials, or try again. Even better would be a separate screen to enter/update credentials separately to trying a connection.

There's no prompt to enter SSH password, so I suspect you're assuming the RPC and SSH passwords are the same. RPC never works for me, but I've set SSH password to same as RPC and tried again - no change, neither RPC nor SSH are ever successful. No firewall, connectivity and passwords confirmed as working, it just doesn't work through FullyNoded.

Have you got physical iPhone devices to test this on?

Fonta1n3 commented 5 years ago

Thanks for the info, yes I have tested thouroughly on physical devices for both RPC and SSH. The app is beta, I am updating and improving all the time. That is a correct assumption about the password for SSH and RPC being the same. The port will be different though. Please just keep updating it in app store. Not sure why its not working for you. Sounds like all the boxes are ticked. Am a bit confused as you say it crashes everytime you add a port? I guess that was a one off crash? Appreciate the feedback.

niallyoung commented 5 years ago

"The port will be different though." - are you saying I need to enter 22 as the RPC Port when entering RPC credentials?

The previous version of the App crashed instantly, the latest version doesn't crash it times out.

Fonta1n3 commented 5 years ago

going to close this as the app does not seem to be shutting down with the new update