Fonta1n3 / FullyNoded

Self sovereign, secure, powerful, easy to use wallet that utilizes your own node as a backend. Powered by PSBT's and descriptors. Acts as an offline signer using your node as a watch-only wallet. C-Lightning compatible for instant, unfairly cheap payments.
https://fullynoded.app
Other
201 stars 31 forks source link

`-duplicate wallet file specified` error when loading a wallet #18

Closed Fonta1n3 closed 4 years ago

Fonta1n3 commented 4 years ago

I am often getting -duplicate wallet file specified when loading a wallet. Nothing fishy or strange happening code wise, it seems like a Bitcoin Core issue. The wallet does in fact get loaded but can be very frustrating in the app, it seems as if the command is being duplicated but in the console output it is not, because an error is returned the wallet does not get saved locally which results in a frustrating feed back loop.

To fix it we should simply join all available wallets into one table view and allow user to simply tap the one they want to work with utilizing our UserDefaults method to save the current active wallet, if reducer returns a wallet not loaded error we can automatically load it in the background.

Preserve the loading/unloading functionality but add an additional "wallets" tab on the bottom where we obfuscate away bitcoin-cli calls a bit to greatly improve the UX.

Fonta1n3 commented 4 years ago

Seems to be the wallet gets loaded then for some reason the response does not propagate back quickly enough over tor so another command is made (hence the duplicate error). Try increasing the timeout for node commands to prevent this.

Fonta1n3 commented 4 years ago

users should not see this anymore