Atomize document fragments (fix for #643)

FontoXML / fontoxpath

A minimalistic XPath 3.1 implementation in pure JavaScript

MIT License

133 stars 17 forks source link

Atomize document fragments (fix for #643) #644

Closed egh closed 3 months ago

egh commented 3 months ago

This seems to work for me - I'm not sure about the implications of the change to ConcreteNode or how to test though - I don't see any explicit tests for atomize.

bundlemon[bot] commented 3 months ago

BundleMon

Unchanged files (2)

Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | fontoxpath.esm.js
| 78.54KB | - :white_check_mark: | fontoxpath.js
| 78.43KB | -

Total files change +6B 0%

Final result: :white_check_mark:

View report in BundleMon website ➡️

Current branch size history | Target branch size history

coveralls commented 3 months ago

coverage: 91.567%. remained the same when pulling d6a4d2ab5a3d8b373dbeffd528a22f463e017814 on egh:atomize-document-fragments into 6a7bd9408552c0409226ecd0cb70bc58c54ffba6 on FontoXML:master.

DrRataplan commented 3 months ago

I added a simple unit test that should cover that uncovered line. I based it on your original bug report :wink:

DrRataplan commented 3 months ago

Merging. Thanks!

egh commented 2 months ago

Thank you!