search

Foo-Foo-MQ / foo-foo-mq

Abstractions around RabbitMQ
MIT License
48 stars 24 forks source link

Correct protocol is 'amqp', not 'amqp://' #26

Closed mick62 closed 2 months ago

mick62 commented 3 years ago

Hi, The official definition of 'protocol' is the name of the protocol. So the correct protocol value is 'amqp'. Currently foo-foo-mq can't establish a connection when given 'amqp' as the protocol in the connection configuration.

Please change the behavior to allow 'amqp' (as well as 'amqp://' for backward compatibility) for the protocol in the connection configuration.

Thanks for your great work.

zlintz commented 3 years ago

@mick62 sounds like you know what to do here. Any interest in contributing a PR and tests for this?

mick62 commented 3 years ago

I would really enjoy to contribute but unfortunately I'm 200% overloaded with other projects.

zlintz commented 1 year ago

@mick62 I am as well, as you can see its been sitting here for awhile (I have a FT job and family first). This is just a side project for me, ie I currently get nothing for this other than the fact I like rabbitmq and would like to help as I can/time allows. If I get time I will look into this but I am looking to the community for help with active changes and fixes.

MartianH commented 3 months ago

@zlintz I am working on a pull request for this and my own issue (#55 )

MartianH commented 2 months ago

@zlintz can this ticket be closed now?

zlintz commented 2 months ago

Fixed by @MartianH in v9.1.0