search

Foo-Foo-MQ / foo-foo-mq

Abstractions around RabbitMQ
MIT License
48 stars 24 forks source link

Update TypeScript typings #39

Open axelo opened 1 year ago

axelo commented 1 year ago

While using the current typings I detected some inconsistency with the underlying JavaScript code. This PR tries to fix that.

Some notable changes are defaulting to unknown instead of any.

The updated typings has been compiled and ran against our internal TypeScript backend successfully.

zlintz commented 1 year ago

I am inclined to accept this change given I don't see anyone else interested in typing things otherwise. Anyone opposed? will leave this a bit longer but this seems reasonable. That said, I may change things in the future but I will version the repo accordingly.

zlintz commented 1 year ago

Any chance you would be willing to update the commit message to align with https://github.com/Foo-Foo-MQ/foo-foo-mq/blob/main/HOW_TO_CONTRIBUTE.md#commit-style and we will get this merged? Also please rebase in the process

zlintz commented 7 months ago

Following up here, is this still something you want? Or others?

zlintz commented 7 months ago

If you still want this please follow https://github.com/Foo-Foo-MQ/foo-foo-mq/blob/main/HOW_TO_CONTRIBUTE.md#commit-style or just rebase and use npm run commit which takes care of it for you. Otherwise I may still just take these change for myself, I would rather you get the credit for the efforts though. These look good overall

axelo commented 7 months ago

If you still want this please follow https://github.com/Foo-Foo-MQ/foo-foo-mq/blob/main/HOW_TO_CONTRIBUTE.md#commit-style or just rebase and use npm run commit which takes care of it for you. Otherwise I may still just take these change for myself, I would rather you get the credit for the efforts though. These look good overall

Really sorry for late answer! Unfortunately I have too little time to fix this, sorry again :/ No worries about credits, please use the parts you deem valid and close this PR.

Thanks for doing this in the first place.