search

Foo-Foo-MQ / foo-foo-mq

Abstractions around RabbitMQ
MIT License
48 stars 24 forks source link

feat(.nvmrc, package.json, info.js, test-coverage-actions.yml): add s… #40

Closed forrest-labrum closed 1 year ago

forrest-labrum commented 1 year ago

…upport for node 18

Adds support for node 18, as it is now LTS. Modifies the hash for unique queue names to use md5 instead of md4, md4 was broken by node 17's upgrade to OpenSSL3.

fix #37

zlintz commented 1 year ago

Oh snap @forrest-labrum !

Thank you for this. I will try to take a look at this sooner than later. The GitHub pipeline I am sure is currently broken (still attempting to move over to it ever since TravisCI stopped being free for open source) but if this runs locally I'll get this in.

forrest-labrum commented 1 year ago

@zlintz no worries, hope you're doing well!

zlintz commented 1 year ago

Hey just checking back on this, in trying to run on node 18 even with this change I am still seeing failed tests. I'm not saying the tests are wrong but they were still working on 16. I think there is something more going on here

zlintz commented 1 year ago

@forrest-labrum hey not sure what change with node or maybe I was just having an issue for a minute with the version of 18 I was using but I just did a release because things are working and passing tests. Look for version 8.0.0

Thanks again!

forrest-labrum commented 1 year ago

@zlintz Ah dang, you had reviewed right before I left for the holidays and I totally forgot about this. Thanks for circling back on it and getting it merged in!

zlintz commented 1 year ago

No problem, I am not sure exactly what was going on, maybe just a local dev env problem, but after I came back to I had no problems. Could have been a bug in an early node 18 version as far as I know because the only thing I can think of I did was get a current copy of 18 (i.e. nvm install) and it was happy