Fix #392 with version check for Anki and Qt

FooSoft / anki-connect

Anki plugin to expose a remote API for creating flash cards.

https://foosoft.net/projects/anki-connect/

Other

1.92k stars 218 forks source link

Closed mikkkee closed 1 year ago

mikkkee commented 1 year ago

Hi,

Some tests are failing due to #392 , there are two kinds of errors

aqt.import_export doesn't exist, it turns out this is only added in Anki 2.1.52. See #1743 in https://github.com/ankitects/anki/compare/2.1.51...2.1.52
Qt.WindowStaysOnTopHint doesn't exist, it turns out it's of a different name in Qt6.

This pull request is to handle both and update doc to make it clear guiImportFile is only supported >=2.1.52

Thanks!

mikkkee commented 1 year ago

Oh looks I need to add a button click after bringing up the import window to avoid timeout

mikkkee commented 1 year ago

Tests are good now 😄

FooSoft commented 1 year ago

Nice, thanks for fixing up the back compat!

mikkkee commented 1 year ago

This test fails, but it looks not related to this change.