search

FooSoft / yomichan-anki

Plugin for sentence/vocab mining Japanese books in Anki.
https://foosoft.net/projects/yomichan-anki
Other
58 stars 12 forks source link

Korean support #10

Closed dayjaby closed 8 years ago

dayjaby commented 9 years ago

Here is the first code of Korean support. I use Javascript code from dbravender/korean_conjugation

Actually, using the Javascript code the way it was (some tricky PyQt code allows to execute Javascript in Python) was too slow. Doing one lookup took about 5 seconds. After using a service like JavascriptCompressor, the lookups are as fast as you are used in Japanese.

The code is still quite error-prone, especially if there is Hanja (Korean version of Kanji) in the text. At the moment, the Japanese translations will be shown too for these Hanja, because they might be Japanese words.

Furthermore there is no distinction between Japanese cards and Korean cards (no distinct profiles), which is going to be necessary at a certain point though, especially if we are going to support more languages.

dayjaby commented 8 years ago

Similar to #9 , there are too many changes which makes merging impractical.