FooSoft / yomichan-import

External dictionary importer for Yomichan.
https://foosoft.net/projects/yomichan-import/
MIT License
83 stars 23 forks source link

some kanji get dropped when converting KANJIDIC2 #34

Open freebiesoft opened 3 years ago

freebiesoft commented 3 years ago

at least one kanji, '剝' , gets dropped when converting from kanjidic2.xml to the ZIP file. This kanji is clearly in the kanjidic2.xml file, but it's not in the converted ZIP file.

rnpnr commented 1 year ago

I looked into this a bit and there are some kanji that get dropped in the xml->yomidict conversion but '剝' isn't one of them. Here is the entry:

[
    "剝",
    "ハク ホク",
    "へ.ぐ へず.る む.く む.ける は.がれる は.ぐ は.げる は.がす",
    "jouyou",
    [
        "come off",
        "peel",
        "fade",
        "discolor"
    ],
    {
        "grade": "8",
        "halpern_kkd": "2105",
        "jis213": "1-15-94",
        "moro": "2049",
        "skip": "1-8-2",
        "strokes": "10",
        "ucs": "525D"
    }
],

The kanji that are skipped are because of the following checks in kanjidic.go:

func kanjidicExtractKanji(entry jmdict.KanjidicCharacter, language string) *dbKanji {
    if entry.ReadingMeaning == nil {
        return nil
    }
...
    if len(kanji.Meanings) == 0 {
        return nil
    }
...
}

which is probably fine for a J-E dictionary like this.

Can you elaborate on where it was you detected this issue (or anyone else with the same issue)?