search

FooSoft / yomichan-import

External dictionary importer for Yomichan.
https://foosoft.net/projects/yomichan-import/
MIT License
83 stars 23 forks source link

[feature request] ignore English or alphanumeric entries #7

Closed ghost closed 7 years ago

ghost commented 7 years ago

It would be great if I could pass in a command line flag to ignore english or alphanumeric entries.

The yomichan extension can get annoying when I type into a text box and hit Shift while my cursor happens to be hovering over an English word contained in an EPWING entry.

FooSoft commented 7 years ago

I think this would make more sense to do on the Yomichan side by blocking search of strings that contain non Hiragana/Katakana/Kanji characters.

Due to issues with shoddy IndexedDB implementation in Chrome, deleting individual dictionaries is not viable. This means that upon discovering that matches to alphanumeric entries are annoying, the user would have to nuke their database and re-import everything, which is a pretty bad workflow.

ghost commented 7 years ago

Yeah that's a good point I'm fine with this functionality being placed into Yomichan although I haven't looked at the Yomichan code at all and have no desire to do those changes there myself.

I'll close this up and make a new issue there.

EDIT: Cotinued here https://github.com/FooSoft/yomichan/issues/47

P.S. as I was typing up this response the exact scenario of the text box popping up because my cursor happened to be hovering over a word happened -_-