toasted-nutbread
commented
3 years ago Quoting feedback from @FooSoft https://github.com/FooSoft/yomichan/issues/1079#issuecomment-739554939:
- The "Show popup preview" toggle jumps to top of the screen when enabled and returns to screen center when disabled. Not sure if it's supposed to do this or if it is a bug (I am getting this on Chromium). When expanded, there is also a lot of vertical white space inserted between the elements. We should probably have the preview contents be right below the toggle and not have the toggle jump around depending on its state. Also, would there ever be a time where the user would not want to display the preview at all?
The reason it jumps is because the <iframe> of the preview isn't visible until it's enabled, causing a layout change. I tested an animation on the frame to prevent the immediate jump (but still moved to top), but there were other issues related to jitter. You're probably right that it may be easiest to have it always visible.
- The link for "Top" which appears after you scroll downwards appears in an area which is already pretty busy and this make it hard to notice. I'm wondering if it would look better in bottom right corner of the screen, as there is nothing currently there and it would be easy to spot. I get that having "top" be at the top of the page makes sense, but in its current form I think a lot of people will not notice it.
May also be viable to just remove it altogether, since it's kind of redundant with the scrollbar or keyboard navigation.
- The popups (Profiles, Dictionaries, etc.) have headings which do not stand out enough IMO. I'm not sure if there's a better style to use here, but there should be something to make them stand out a little better.
They do kind of blend in; I wonder to what extent that might affect usability. The design is similar to the design of Chrome's settings page, and it uses this same design. A few things I can think of:
- Add an "..." to better indicate that clicking the option will open a popup/panel of some sort.
- Hover color/background change to better indicate interactivity (on devices that support hover).
- Active color/background change.
The popups always open in full-height which can seem to be a bit overkill if there is not a lot of info to display.
The full-height ones were sized that way based on a use case where there is a lot of info in them. The two main ones which may contain "dead space" may be:
- Dictionaries - when empty, it's pretty bare, but if a user installs several dictionaries, e.g. 4-5, it fills up pretty well. Maybe the average user is only installing only one though (JMDict), so might be worth making it smaller.
- Anki card format - also pretty empty if there are very few fields; some of my testing had 10+ fields, so that's partially why I used the full size. May be worth using the smaller version.
I could have also gone the route of making the height expand based on content, but I chose not to do that for now because of how it affects button/input positions as entries are added/removed.
We can probably get rid of the whole About/Donate/whatever thing. There's really not really a lot that needs to be said "about" Yomichan and considering that this is a more distributed development effort at this point, having a "donation" thing there is strange too, especially considering that project has no direct monetary expenses at this point.
...with that being said, maybe have some sort of "Help" or "Report a bug" or something link that sends the user to GitHub?
I plan on having a general info page which shows links to the homepage, Github, version info, licenses, extension permissions, etc. So it won't be completely removed, but it will be changed to something with more info. The ? button on the action popup will probably also direct to that.
Thermospore
PhantomAvery
FirionHope
fmy1993
Aridow
This issue is for any questions/comments/feedback related to the new settings page.
Changes: