search

FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.06k stars 213 forks source link

i dislike the blue #1142

Closed MrD0lph closed 3 years ago

MrD0lph commented 3 years ago

(Describe the feature or change)

toasted-nutbread commented 3 years ago

Noted; the blue text is a bug, and some alternatives to the blue bar selection indicator have been implemented and will be queued for a patch release.

Thermospore commented 3 years ago

That text coloring is intentional in Group related terms mode, right? I find it quite useful there image (and personally I like it in Group term-reading pairs mode too 🤷 )

As for the blue Current entry bar, it grew on me pretty quick. I think it looks sleeker than the gold star. The transition animations look nice

The new transport controls look nice. Though, they are now on the opposite side of where you would usually click on a kanji, but that's nbd image (I know there is a kb shortcut to go back, but Language Learning with Netflix steals focus from yomichan so you have to use the mouse)

Thermospore commented 3 years ago

Oh sweet, I see the transport position is already addressed in https://github.com/FooSoft/yomichan/issues/1079#issuecomment-748549527 and that the text coloring is intentional in Group related terms mode 👍

tvvoty commented 3 years ago

Yeah, dark saturated blue clashes a lot against black background, wish it was possible to disable it or at least change the color.

toasted-nutbread commented 3 years ago

An update is coming soon to fix that issue; the blue color has been updated to have better contrast against the dark background. Also, the text color should be reverted back to the white color for certain display modes.

Left: old; Right: new image