Open Thermospore opened 3 years ago
Originally just had no.1; turning this into a general image improvements issue
On a different note, I think it would look better if there's a shadow for pop-up images on compact mode, as the backgrounds of the image may blend with Yomichan's background, making it look weird, at least for me
Oh, and the extra "dead" space you're seeing is supposed to be to size the image container to its natural size, but that may be broken or the image may be acting strangely. That padding shouldn't be there for a correct case.
I believe 2 and 4 are related, and the attached dictionary should be able to reproduce them (look up the word sample
)
sample-image.zip
In addition, I think "Description B" for the sample dictionary should be centered, if you decide to keep the behavior of centering "sample-b.png"
梅
in these two dicts:
大辞林 第三版(画像のみ) (v2).zip
デジタル大辞泉.zipthanks!
new changes lookin good :)
1. Make compact glossary image hyperlinks blue
easy to miss otherwise :)
here is what it looks like the same color as the
Log debug info to console
hyperlinkcss:
.gloss-image-link {color: #4a91ed;}
2. Sometimes compact glossary hover images have unneeded background / offset
background
offset
no issue (for reference)
3. Compact glossary hover images are rather small, should have a setting to change it
4. In non-compact mode, default image css isn't optimal in many cases
images often flow out of the border and or have unneeded background / offset sometimes the text wrap gets broken by this as well
example 1: offset + flows off page + broken text wrap original image (had to zip it cos github doesn't support webp) screenshot of popup window
example 2: background + flows off page original image stitched screenshot of the search page
5. Should also have an option to control the max size (esp height) of image in non-compact mode